New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with Parameters Passed in the URL #2124
Comments
Are you sure that your uri .... parameters are formed correctly ? https://www.rfc-editor.org/rfc/rfc3986#section-2.2 I think you have a problem with the "==" in your string. The "sign" is a reserved sub-delim character https://www.rfc-editor.org/rfc/rfc3986#section-2.1 Probably Bruno is not handling / showing the data for this reason not correctly in your first screenshot |
I think this is a serious bug and important feature to fix, but it comes with a bunch of design decisions to make. The URL field should probably validate its contents and notify user if the value is not correctly formatted URL - and what @Chibane690 inputs is in fact invalid. Is bruno supposed to silently try to url encode the value of URL field? What request is actually being sent from this example? What if loading a bru file where the query section does not match url section? Which takes precedence? It would be nice to have an input from maintainers (@helloanoop) on their vision for this, so someone could pick this up. A UI solution in this particular case would look something like this, I think - but it takes more than that to iron out this issue: Params from URL converted on the fly (assuming user types in url-encoded format, which is perhaps much to ask from a human). |
I downloaded the Postman client to perform the same test, and it worked well. It escaped the quotes but not the "==" when sending the request, rather than during inputting the request. Here's a screenshot illustrating the request input: And here's the image during the request emission: The execution went smoothly without any bugs. |
The '=' should be allowed within query parameter value. While first equals sign separates parameter name from its value, any subsequent occurrences are valid and should not be discarded.
I have checked the following:
Describe the bug
I added a parameter "q" directly into the URL bar to be executed without going through the query array as illustrated in the image below:
When I added another parameter from the query array, in my case it was the "options" attribute with the value "concise", it modified the value of the "q" attribute that I associated at the beginning, which caused a bug as illustrated in the image below:
.bru file to reproduce the bug
No response
Screenshots/Live demo link
The text was updated successfully, but these errors were encountered: