Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This one is optional, but we should be using static analysis and linter tools to have a better codebase. A popular stack is: mypy, black, ruff, and isort. We can make use of these tools. #9

Open
chronark opened this issue May 28, 2023 · 2 comments
Open

This one is optional, but we should be using static analysis and linter tools to have a better codebase. A popular stack is: mypy, black, ruff, and isort. We can make use of these tools. #9

chronark opened this issue May 28, 2023 · 2 comments

Comments

@chronark
Copy link

This one is optional, but we should be using static analysis and linter tools to have a better codebase. A popular stack is: mypy, black, ruff, and isort. We can make use of these tools.
@chronark
Copy link
Author

sgtm

@TudorZgimbau
Copy link
Contributor

Strictly speaking mypy, I've used it and manually checked a lot of errors. While it's very useful if you have the patience to distinct between false positives and actual errors, I wouldn't block anything because of it (especially if the other tests are passing). Related to this typing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chronark @TudorZgimbau