Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ioredis compatibility #115

Open
bkniffler opened this issue Jul 22, 2024 · 7 comments
Open

ioredis compatibility #115

bkniffler opened this issue Jul 22, 2024 · 7 comments

Comments

@bkniffler
Copy link

Any chance we could get this ioredis compatible? Would like to use upstash via ioredis to remove http overhead, and ioredis is one of the recommended clients for upstash, but its not compatible with ratelimit-js.

@ogzhanolguncu
Copy link
Contributor

ogzhanolguncu commented Jul 23, 2024

Totally doable, but our main focus on serverless environments. Maybe we can let people use ioredis and/or redis for serverful environments. I'll discuss this with the team.

Edit:
For now you can do the following -> #60

@sourabpramanik
Copy link
Contributor

@ogzhanolguncu If the team is moving forward with this integration, I would like to work on it.

@bkniffler
Copy link
Author

@ogzhanolguncu the linked solution does not work, up stash rate limit depends on more functions by now.
hset, evalsha, scriptLoad, smismember, multi

Bildschirmfoto 2024-07-26 um 11 16 44

using ioredis for these methods seems to not work either out of the box, think the adapter needs more effort to be made working. would love this to be part of ratelimit-js, then at least its clear when compatibility breaks.

@bkniffler
Copy link
Author

Any chance this is going to land sometime?

@ogzhanolguncu
Copy link
Contributor

Sorry to say that, but team don't wanna move forward with that approach for now. But, we can't say you guys can't come up with an adapter 😉 If you know what I mean. So feel free to @sourabpramanik or @bkniffler make your own adapters.

@sourabpramanik
Copy link
Contributor

Gotcha @ogzhanolguncu

@ogzhanolguncu
Copy link
Contributor

If you have a working solution make sure to put it here so other people can use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants