-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for retry merge-gatekeeper failure #41
Comments
Hi @aradwyr, thanks for filing an issue! Could you please elaborate what you mean by "merge-gatekeeper failure"? Merge Gatekeeper does simple polling for the predefined timeout duration (default set to 600 sec), and if it exceeds that it goes to the failure state. If some jobs took longer than 10 min, you can simply rerun Merge Gatekeeper job - do you mean to get some other control for such a rerun? |
If we retry a failing job (terrible practice, but zealously worshipped by engineers) , that job passes, and we rerun merge gatekeeper, merge gatekeeper will still pick on the failing job although now it passes. The solution becomes |
@markrmullan maybe you can forward this to the right person since I've left |
It'd be helpful to be able to retry in the event of a merge-gatekeeper failure
The text was updated successfully, but these errors were encountered: