Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Incorrect viewport position for multi-line menus #1522

Open
ispitsyn opened this issue Dec 25, 2024 · 1 comment
Open

[Bug]: Incorrect viewport position for multi-line menus #1522

ispitsyn opened this issue Dec 25, 2024 · 1 comment
Labels
bug Something isn't working v2

Comments

@ispitsyn
Copy link

radix-vue/packages/core/src/NavigationMenu/NavigationMenuViewport.vue

Line 115 in ebabbb8

posTop = screenOffset - rootRect.top

In the updatePosition function, the following line is used:
posTop = screenOffset - rootRect.top

It is suggested to replace this line with:
posTop = screenOffset - rect.top

This change will correctly account for the offset of each menu line, resolving the display issue.
@ispitsyn ispitsyn changed the title Incorrect viewport position for multi-line menus [Bug]:Incorrect viewport position for multi-line menus Dec 25, 2024
@ispitsyn ispitsyn changed the title [Bug]:Incorrect viewport position for multi-line menus [Bug]: Incorrect viewport position for multi-line menus Dec 25, 2024
@zernonia zernonia added the v2 label Dec 30, 2024
@zernonia
Copy link
Member

Thanks for pointing this out @ispitsyn ! Do you mind sharing the issue with using rootRect.top? 😁
Also, PR is always welcomed!

@zernonia zernonia added the bug Something isn't working label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working v2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zernonia @ispitsyn