Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Holding state #19113

Open
HakanL opened this issue Dec 21, 2024 · 0 comments
Open

Inconsistent Holding state #19113

HakanL opened this issue Dec 21, 2024 · 0 comments
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification

Comments

@HakanL
Copy link

HakanL commented Dec 21, 2024

Current behavior

I catch the Holding event on a Card and if I get the holding event then I navigate to a different screen (think "options" for an item). If I tap the card then I execute the command for the card (it's like a menu). The issue is that if I hold, navigate to the options screen and then back. If I tap the same card then the Holding event is triggered when I expected the Tapped event. I log when the screen is tapped/released, and I added a log event for the Holding event and I see this:

18:41:19.193 VRB [App] Pointer pressed at 135:105 Contact: True
18:41:19.371 VRB [App] Pointer released at 135:107
18:41:20.003 VRB [MenuPage] Card holding state: Started

Basically the holding event came in 630 ms after the screen was released. I tapped the screen in 178 ms so that shouldn't start a holding event. If I instead of triggering my hold event when the state is Completed then the action is way too long, I have to hold for a long time which isn't a good user experience.
My preference would be to control the hold threshold and how long the user has to hold, but there still seems to be an issue with how the holding event is raised. Perhaps it's because I'm navigating to a different view and that doesn't reset the holding timer for something? Here's the log for when the holding event isn't triggered:

18:50:47.787 VRB [App] Pointer pressed at 169:101 Contact: True
18:50:47.957 VRB [App] Pointer released at 169:100

Basically the same type of tap, 170 ms, but no holding event is raised.

Expected behavior

Consist holding event every time I tap/hold a card

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

No response

Works on UWP/WinUI

None

Environment

Uno.UI / Uno.UI.WebAssembly / Uno.UI.Skia

NuGet package version(s)

"Uno.Sdk.Private": "5.6.0-PullRequest-19054-150374-19054.1190"

Affected platforms

Skia (Linux X11)

IDE

Visual Studio 2022

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

@HakanL HakanL added difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification labels Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification
Projects
None yet
Development

No branches or pull requests

1 participant