Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WASM] TextBox does not properly keep the focus when in a Flyout/Popup #18790

Closed
DierkDroth opened this issue Nov 14, 2024 · 9 comments · Fixed by #18887
Closed

[WASM] TextBox does not properly keep the focus when in a Flyout/Popup #18790

DierkDroth opened this issue Nov 14, 2024 · 9 comments · Fixed by #18887
Assignees
@ramezgerges
Labels
area/autosuggestbox Categorizes an issue or PR as relevant to the AutoSuggestBox control area/focus Categorizes an issue as relevant to focus management difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/bug Something isn't working

Comments

@DierkDroth
Copy link

DierkDroth commented Nov 14, 2024 •
edited
Loading

Current behavior

Please see repo below: when upgrading from UNO 5.2 -> 5.3 the AutoSuggestBox is screwed up when clicking before starting to type: the selection logic no longer works. Same when updating the repo to .NET 9 and latest UNO 5.5.

Minimal.zip

@jeromelaban my team and I again spent a lot of time chasing down this regression. Together with the other regressions I reported earlier (here and here) we're still forced to stay with UNO 5.1 (!). I'm happy to continue investing resources and time in chasing down UNO regressions, but I also would appreciate if the regressions would be taken care of in not too far future. Thanks in advance

Expected behavior

No response

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

No response

Works on UWP/WinUI

None

Environment

Uno.WinUI / Uno.WinUI.WebAssembly / Uno.WinUI.Skia

NuGet package version(s)

No response

Affected platforms

No response

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response
@DierkDroth DierkDroth added difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification labels Nov 14, 2024
@jeromelaban jeromelaban changed the title [WASM] [Regression] AutoSuggestBox is screwed up when upgrading UNO 5.2 -> 5.3 (and with UNO 5.5 still) [WASM] AutoSuggestBox selection logic is not working Nov 15, 2024
@jeromelaban
Copy link
Member

jeromelaban commented Nov 15, 2024 •
edited
Loading

Thanks Dierk. We appreciate the time you're spending entering issues. As you know, we're prioritizing issue based on our enterprise clients and we'll take a look at this issue when possible.

@DierkDroth
Copy link
Author

DierkDroth commented Nov 15, 2024 •
edited
Loading

@jeromelaban to be clear: this is not just an issue but a regression. As such, this was working before and now no longer is working. I took the liberty to reflect this on the title of my report.

Please let me know if you felt this is not a regression. Thanks

@DierkDroth DierkDroth changed the title [WASM] AutoSuggestBox selection logic is not working [WASM] [Regression] AutoSuggestBox no longer working when upgrading UNO 5.2 -> 5.3 (and with UNO 5.5 still) Nov 15, 2024
@jeromelaban
Copy link
Member

jeromelaban commented Nov 15, 2024 •
edited
Loading

Thanks. This is not an AutoSuggestBox issue, but rather a focus issue for TextBox when located in a Flyout/Popup.

This is a specialized repro: https://playgroundcanary.z19.web.core.windows.net/#92ea19af which uses Uno 5.6-dev.

@jeromelaban jeromelaban changed the title [WASM] [Regression] AutoSuggestBox no longer working when upgrading UNO 5.2 -> 5.3 (and with UNO 5.5 still) [WASM] TextBox does not properly keep the focus when in a Flyout/Popup Nov 15, 2024
@DierkDroth
Copy link
Author

Thanks @jeromelaban. That makes sense, since we saw 'weird' issues related to TextBox on Flyouts as well, but it ultimately was more efficient for us to isolate the issue on AutoSuggestBox ... interesting

Nevertheless this is a regression, correct?

@MartinZikmund MartinZikmund added difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI area/focus Categorizes an issue as relevant to focus management area/autosuggestbox Categorizes an issue or PR as relevant to the AutoSuggestBox control and removed triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Nov 21, 2024
@ramezgerges ramezgerges self-assigned this Nov 21, 2024
@ramezgerges ramezgerges mentioned this issue Nov 22, 2024
Merged
6 tasks
@DierkDroth
Copy link
Author

Thanks for taking care @ramezgerges. We'll run tests as a build is available...

@DierkDroth
Copy link
Author

DierkDroth commented Dec 5, 2024 •
edited
Loading

@ramezgerges I just upgraded to 5.5.87 but found that the issue persists. What am I missing?

@ramezgerges
Copy link
Contributor

ramezgerges commented Dec 5, 2024 •
edited
Loading

This PR is not in any stable release (yet). You can try with a recent dev version (e.g. 5.6.0-dev.1063).

@jeromelaban
Copy link
Member

@DierkDroth this fix will only be present in 5.6 when it will be released.

@DierkDroth
Copy link
Author

@jeromelaban @ramezgerges thanks for clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ramezgerges ramezgerges

Labels
area/autosuggestbox Categorizes an issue or PR as relevant to the AutoSuggestBox control area/focus Categorizes an issue as relevant to focus management difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(textbox): losing focus on PointerUp when inside a Popup on WASM ramezgerges/uno
4 participants
@MartinZikmund @jeromelaban @DierkDroth @ramezgerges