Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android][WCT - WrapPanel] Fluent buttons change size upon click inside the WrapPanel #16595

Open
agneszitte opened this issue May 6, 2024 · 4 comments
Labels
difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/bug Something isn't working platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform project/layout 🧱 Categorizes an issue or PR as relevant to layouting and containers (Measure/Arrange, Collections,..)

Comments

@agneszitte
Copy link
Contributor

agneszitte commented May 6, 2024

Current behavior

Fluent buttons change size upon click inside the Windows Community Toolkit WrapPanel but only for Android.

1b004bc23346b2572e74aee00c655c16.mp4

Expected behavior

No size change for the Fluent buttons like for Windows and other platforms.

c5d5c5fac4980f96d1e97aa475361ed7.mp4

How to reproduce it (as minimally and precisely as possible)

Click on the fluent buttons inside the WCT WrapPanel and notice the issue.

Note

For WCT (v. 7.1.2): xmlns:controls="using:CommunityToolkit.WinUI.UI.Controls"
For WCT (v. 8.1.240328-rc): xmlns:controls="using:CommunityToolkit.WinUI.Controls"

 <Grid>

   <Grid.RowDefinitions>
     <RowDefinition Height="Auto" />
     <RowDefinition Height="*" />
   </Grid.RowDefinitions>

   <TextBlock Margin="24,48,0,0"
              FontSize="24"
              Text="Test Uno Platform" />

   <controls:WrapPanel Grid.Row="1"
                       Margin="24,24,0,0">

     <Button x:Name="B1"
             Margin="0,0,16,8"
             Content="Button 1" />
     <Button x:Name="B2"
             Margin="0,0,16,8"
             Content="Button 2" />
     <Button x:Name="B3"
             Margin="0,0,16,8"
             Content="Button 3" />
     <Button x:Name="B4"
             Margin="0,0,16,8"
             Content="Button 4" />
     <Button x:Name="B5"
             Margin="0,0,16,8"
             Content="Button 5" />
     <Button x:Name="B6"
             Margin="0,0,16,8"
             Content="Button 6" />
     <Button x:Name="B7"
             Margin="0,0,16,8"
             Content="Button 7" />

   </controls:WrapPanel>

 </Grid>

Workaround

N/A

Works on UWP/WinUI

Yes

Environment

Uno.UI / Uno.UI.WebAssembly / Uno.UI.Skia

NuGet package version(s)

     "Uno.Sdk": "5.2.108"
    <UnoExtensionsVersion>4.1.21</UnoExtensionsVersion>
    <UnoToolkitVersion>6.0.18</UnoToolkitVersion>
    <UnoThemesVersion>5.0.13</UnoThemesVersion>
    <UnoCSharpMarkupVersion>5.2.13</UnoCSharpMarkupVersion>
    For WCT (v. 7.1.2) OR (v. 8.1.240328-rc). See sample apps in the repro details above.

Affected platforms

Android

IDE

Visual Studio 2022

IDE version

17.9.6

@agneszitte agneszitte added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels May 6, 2024
@agneszitte
Copy link
Contributor Author

cc @MartinZikmund, @Youssef1313 in case you have an idea on the root cause

@Youssef1313 Youssef1313 added platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform project/layout 🧱 Categorizes an issue or PR as relevant to layouting and containers (Measure/Arrange, Collections,..) labels May 6, 2024
@MartinZikmund MartinZikmund added difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI and removed triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels May 9, 2024
@MartinZikmund
Copy link
Member

Seems like some kind of layouting issue, maybe it is trying to do layout while layouting is in progress?

@jeromelaban
Copy link
Member

@Youssef1313 could you try it with your lifecycle PR update?

@Youssef1313
Copy link
Member

It probably shouldn't have an impact as the enhanced lifecycle is only done for Skia/Wasm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/bug Something isn't working platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform project/layout 🧱 Categorizes an issue or PR as relevant to layouting and containers (Measure/Arrange, Collections,..)
Projects
None yet
Development

No branches or pull requests

4 participants