Add error when Processor Architecture doesn't match Runtime #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromelaban
approved these changes
May 9, 2024
agneszitte
approved these changes
May 9, 2024
|
There's no obvious way to determine which architecture will be used by msbuild at this point. We'll revisit this in the future if the error becomes more common. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If the Processor Architecture does not match the Runtime Architecture of the dotnet tooling an invalid runtime will be selected by for the compiled runtime assets for SkiaSharp
What is the new behavior?
If there is a mismatch on Windows where the Processor is x86 and the runtime is x64 we will now raise a build error letting you know that the environment is not valid. This includes a check for
AMD64so that we normalize this value allowing the check to pass forx64since the two are compatible.