Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Platform-specific customization #261

Open
Tracked by #265
MartinZikmund opened this issue May 6, 2024 · 4 comments
Open
Tracked by #265

[Docs] Platform-specific customization #261

MartinZikmund opened this issue May 6, 2024 · 4 comments
Assignees
Labels
kind/consumer-experience Categorizes issue or PR as related to improving the experience of consumers kind/documentation Categorizes an issue or PR as relevant to 3rd party dependencies that are consumed by this project triage/untriaged Indicates an issue requires triaging or verification.

Comments

@MartinZikmund
Copy link
Member

What would you like clarification on:

How to customize properties per-platform.

e.g. ForegroundScale has a specific property per target:

image

But what if user wants to have custom background color per target? (This property could probably be renamed to BackgroundColor as it is not clear now from name)

image

This is a common scenario, eg. on Windows and WASM one would usually want background of the icon and splash to be transparent, but maybe not on others.

@MartinZikmund MartinZikmund added kind/consumer-experience Categorizes issue or PR as related to improving the experience of consumers kind/documentation Categorizes an issue or PR as relevant to 3rd party dependencies that are consumed by this project triage/untriaged Indicates an issue requires triaging or verification. labels May 6, 2024
@Kunal22shah Kunal22shah self-assigned this May 14, 2024
@agneszitte
Copy link
Contributor

agneszitte commented May 24, 2024

@Kunal22shah not sure if all these details left by @MartinZikmund are properly taken into account in the latest documentation update. https://platform.uno/docs/articles/external/uno.resizetizer/doc/using-uno-resizetizer.html

@MartinZikmund do you think https://platform.uno/docs/articles/external/uno.resizetizer/doc/uno-resizetizer-properties.html needs more updates?

@MartinZikmund
Copy link
Member Author

This is a ver nice update, much better docs, thanks @Kunal22shah !

One more thing comes to mind related to this - do we support customising the properties for Skia Desktop WPF vs macOS vs Linux? Because I imagine for example the icon scale will need to be different on Windows vs macOS? If yes, we should document it, and if not, we should add such support, as it will be certainly needed

@MartinZikmund
Copy link
Member Author

On the uno-resizetizer-properties page - I’m not sure why we need those platform specific property names ( like AndroidForegroundScale), if using the Condition syntax works for all properties? Maybe we could just remove them from the docs in favour of the “general” property?

@agneszitte
Copy link
Contributor

agneszitte commented May 24, 2024

On the uno-resizetizer-properties page - I’m not sure why we need those platform specific property names ( like AndroidForegroundScale), if using the Condition syntax works for all properties? Maybe we could just remove them from the docs in favour of the “general” property?

What do you think @dansiegel, @jeromelaban ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/consumer-experience Categorizes issue or PR as related to improving the experience of consumers kind/documentation Categorizes an issue or PR as relevant to 3rd party dependencies that are consumed by this project triage/untriaged Indicates an issue requires triaging or verification.
Projects
None yet
Development

No branches or pull requests

3 participants