feat(preset-mini): pseudo-class function for custom arguments #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unocss ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
antfu
reviewed
Jun 2, 2023
| matcher: reset, | ||
| handle: (input, next) => next({ | ||
| ...input, | ||
| selector: `.group:has(${bracketValue}) ${input.selector || ''}`, |
There was a problem hiding this comment.
We have an option to toggle .group style:
There was a problem hiding this comment.
I have done this and moved to the preset-mini package, had to add some code because the previous implementation might work not perfectly with custom arguments (and I'm kinda confused with it).
And implement both four pseudo-class functions with it (so change the pr title
antfu
reviewed
Jun 2, 2023
| matcher: reset, | ||
| handle: (input, next) => next({ | ||
| ...input, | ||
| selector: `.peer:has(${bracketValue}) ~ ${input.selector || ''}`, |
enpitsuLin
changed the title
:has(...) pseudo-class
enpitsuLin
commented
Jun 3, 2023
| `${parent}${escapeSelector(label)}${pseudo}`, | ||
| ] | ||
| } | ||
|
|
||
| return { | ||
| name: `pseudo:${tag}`, | ||
| match(input, ctx) { | ||
| if (!(splitRE && pseudoRE && pseudoColonRE)) { | ||
| splitRE = new RegExp(`(?:${ctx.generator.config.separators.join('|')})`) | ||
| pseudoRE = new RegExp(`^${tag}-(?:(?:(${PseudoClassFunctionsStr})-)?(${PseudoClassesStr}))(?:(/\\w+))?(?:${ctx.generator.config.separators.join('|')})`) |
There was a problem hiding this comment.
confused me on this, it seems can implement custom arguments at the beginning, but didn't
don't know if there has some edge case that I just add code
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addhas-*,group-has-*, andpeer-has-*support for the:has()pseudo-classThis PR implements both
:not()/:is()/:where()/:has()pseudo-class function and its parent variant with custom arguments.Usage
Only pseudo-class
/w parent variant
Work with both
.group/.parent/.peer/.previous