Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strategie Import Specifier to Uri Map. aka loader.input = MapObject #3

Open
1 of 2 tasks
Tracked by #6
lemanschik opened this issue Nov 21, 2022 · 0 comments
Open
1 of 2 tasks
Tracked by #6

Comments

@lemanschik
Copy link
Contributor

lemanschik commented Nov 21, 2022

Strategie Import Specifier to Uri Map. aka loader.input = MapObject

code-oss has references to 'loader!./' Uri specifications
code-oss has references to 'vs/'
code-oss has references to 'vs/
.json'
code-oss has loaders in ./src/.js src/vs/.js src/vs/*.ts the main loader is a extra repo called vscode-loader

export const codeOssImportMap = {
  'vs/editor/browser/editorBrowser': './build/code-oss-dev/src/vs/editor/browser/editorBrowser.ts',
  'vs/css!./standaloneQuickInput': './build/code-oss-dev/src/vs/editor/standalone/browser/quickInput/standaloneQuickInput.css',
}

map rules by file structure is possible with relative pathes as we lookup pathes anyway we can specifie vs/css!./ alwaysrelativ as specifier as it looks like it is always relativ used also vs/* needs only mappings to the .ts extension

also remember that the product.json methods get deprecated: by vscode-build/repos/code-oss-dev/src/vs/platform/product/common/productService.ts

Found a Related issue

We can simply drop the vscode-loader adoption as they drop that dept them self. anyway we will Execute more fast so we do so but we will throw away loader compat for the build process......

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant