Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Netlify, Next, Unkey Starter #598

Closed
wants to merge 14 commits into from
Closed

feat: Netlify, Next, Unkey Starter #598

wants to merge 14 commits into from

Conversation

glamboyosa
Copy link
Contributor

What does this PR do?

This PR is a starter for Next.js, Netlify and Unkey

Fixes # (issue)

Closes #597

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • [x ] Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2023 •
edited

⚠️ No Changeset found

Latest commit: 9aeea31

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 22, 2023

@glamboyosa is attempting to deploy a commit to the Unkey Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 22, 2023 •
edited

Thank you for following the naming conventions for pull request titles! 🙏

@glamboyosa glamboyosa changed the title Netlify, Next, Unkey Starter feat: Netlify, Next, Unkey Starter Nov 22, 2023
@vercel Vercel
Copy link

vercel bot commented Nov 22, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unkey ❌ Failed (Inspect) Nov 28, 2023 2:38pm

@glamboyosa
Copy link
Contributor Author

Fixed merge conflict via: git checkout main -- pnpm-lock.yaml and updated from main @chronark

@perkinsjr
Copy link
Collaborator

Can you pull latest and run

pnpm i

And push back up

ERR_PNPM_OUTDATED_LOCKFILE  Cannot install with "frozen-lockfile" because pnpm-lock.yaml is not up to date with examples/next-unkey-netlify-starter/package.json
09:38:40.440

@glamboyosa
Copy link
Contributor Author

Can you pull latest and run

pnpm i

And push back up

ERR_PNPM_OUTDATED_LOCKFILE  Cannot install with "frozen-lockfile" because pnpm-lock.yaml is not up to date with examples/next-unkey-netlify-starter/package.json
09:38:40.440

@perkinsjr just did :)

@chronark
Copy link
Collaborator

We moved examples to https://github.com/unkeyed/examples

@chronark chronark closed this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perkinsjr perkinsjr Awaiting requested review from perkinsjr perkinsjr is a code owner

@chronark chronark Awaiting requested review from chronark chronark is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Netlify Starter for Unkey
4 participants
@glamboyosa @CLAassistant @perkinsjr @chronark