Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add releases page that leverages ungh #32

Open
2 tasks done
cpreston321 opened this issue Jan 30, 2024 · 10 comments · May be fixed by #91
Open
2 tasks done

Add releases page that leverages ungh #32

cpreston321 opened this issue Jan 30, 2024 · 10 comments · May be fixed by #91
Assignees
Labels
enhancement New feature or request

Comments

@cpreston321
Copy link
Member

cpreston321 commented Jan 30, 2024

Describe the feature

Releases Page

Since we already capture the github repo org/repo we can then leverage that to make something like.

CleanShot 2024-01-30 at 14 50 12@2x

Deps

  • date-dns

Endpoints to use:


Could make a simpler landing page but I really like the design and approach they took but just an idea.

Additional information

  • Would you be willing to help implement this feature?

Tasks

@pi0
Copy link
Member

pi0 commented Jan 30, 2024

Seems a very good idea! If you feel up to it, feel free to self-assign and work on this page!

@cpreston321
Copy link
Member Author

@pi0 Work is pretty much done, if we want to leverage the ugh I will have to make a PR there to support repo/unjs/docs/pulls so we don't have to install another dep for Octokit. I will create issue and attach issue here to track 👍🏼

@cpreston321 cpreston321 self-assigned this Jan 30, 2024
@cpreston321 cpreston321 added the enhancement New feature or request label Jan 30, 2024
@pi0
Copy link
Member

pi0 commented Jan 30, 2024

Thanks. If possible it would be better that we reply on default releases formating in release notes (generated during release with changelogen). They are already mapped to PRs with a reference.

@cpreston321
Copy link
Member Author

@pi0 Only reason I said ungh was because it's more of interactive timeline changelog vs just a full changelog which is generated from README. Either way I can implement I think it's quite interesting seeing the pull requests and new releases on timeline vs just the log.

@cpreston321
Copy link
Member Author

@pi0 what do you think?

CleanShot.2024-02-22.at.16.40.15.mp4

@pi0
Copy link
Member

pi0 commented Mar 4, 2024

Oh sorry i have missed this @cpreston321 do you have your branch drafted somewhere still?

@cpreston321
Copy link
Member Author

@pi0 The POC I drafted above was using ungh /releases endpoint but the problem was the cache would hold too long. If new releases. I think if we wanted to leverage we would need to figure how to clear the ungh cache. If not I will have to use the changelog file but doesn't have the date meta data tied to this.

I did not unfortunately create a branch for this. I can gather your thoughts then I re-implement it.

@pi0
Copy link
Member

pi0 commented Mar 4, 2024

Having a branch would be good start to play around different ideas 👍🏼 I am thinking that automd can sync back and add meta from github releases back to the CHANGELOG.md it can be most reliable source without worrying to be broken 😅

@cpreston321
Copy link
Member Author

I will darft PR later today with ungh implementation then we work from there 💯

@cpreston321
Copy link
Member Author

I am thinking that automd can sync back and add meta from github releases back to the CHANGELOG.md

I think that would be great :)

@cpreston321 cpreston321 linked a pull request Mar 4, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants