Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for breaking change token in the message footer #168

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jboix
Copy link

@jboix jboix commented Jan 15, 2024

πŸ”— Linked issue

#112

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves #112

Extends support for signalling breaking changes in commit messages according to the Conventional Commits Specification (see points 11, 12, 13, 15 and 16).

Previously, only the suffix ! after the type/scope was recognized as a breaking change. With this change, the footer "BREAKING CHANGE" or "BREAKING-CHANGE" will also be identified (as per point 11, 12 and 16 of the specification), these are NOT case-sensitive (as per point 15 of the specification).

The footer BREAKING CHANGE can be omitted as per point 13 of the specification.

Additionally, the description given in BREAKING CHANGE will be used if present instead of the commit description unless the commit includes the ! suffix after the type/scope (as per point 12 of the specification).

For reference these are the points of the specifications that are being implemented:

11: Breaking changes MUST be indicated in the type/scope prefix of a commit, or as an entry in the footer.
12: If included as a footer, a breaking change MUST consist of the uppercase text BREAKING CHANGE, followed by a colon, space, and description, e.g., BREAKING CHANGE: environment variables now take precedence over config files.
13: If included in the type/scope prefix, breaking changes MUST be indicated by a ! immediately before the :. If ! is used, BREAKING CHANGE: MAY be omitted from the footer section, and the commit description SHALL be used to describe the breaking change.
15: The units of information that make up Conventional Commits MUST NOT be treated as case sensitive by implementors, with the exception of BREAKING CHANGE which MUST be uppercase.
16: BREAKING-CHANGE MUST be synonymous with BREAKING CHANGE, when used as a token in a footer.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Extends support for signaling breaking changes in commit messages according to the
[Conventional Commits Specification](https://www.conventionalcommits.org/en/v1.0.0/#specification)
(see points 11, 12, 13, 15 and 16).

Previously, only the suffix "!" after the type/scope was recognized as a
breaking change. With this change, the footer "BREAKING CHANGE" or "BREAKING-CHANGE" will also be
identified (as per point 12 and 16 of the specification), these are NOT case-sensitive
(as per point 15 of the specification).

The footer `BREAKING CHANGE` can be omitted as per point 13 of the specification.

Additionally, the description given in `BREAKING CHANGE` if present instead of the commit
description as per point 12 of the specification

For reference these are the points of the specifications that are being implemented:

11. Breaking changes MUST be indicated in the type/scope prefix of a commit, or as an entry in the
    footer.
12. If included as a footer, a breaking change MUST consist of the uppercase text BREAKING CHANGE,
    followed by a colon, space, and description, e.g., BREAKING CHANGE: environment variables now
    take precedence over config files.
13. If included in the type/scope prefix, breaking changes MUST be indicated by a ! immediately
    before the :. If ! is used, BREAKING CHANGE: MAY be omitted from the footer section, and the
    commit description SHALL be used to describe the breaking change.
15. The units of information that make up Conventional Commits MUST NOT be treated as case
    sensitive by implementors, with the exception of BREAKING CHANGE which MUST be uppercase.
16. BREAKING-CHANGE MUST be synonymous with BREAKING CHANGE, when used as a token in a footer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add breaking changes message to changelog
1 participant