Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with elasticsearch>=1.8.0 #65

Open
miltontony opened this issue Oct 15, 2015 · 11 comments
Open

Not compatible with elasticsearch>=1.8.0 #65

miltontony opened this issue Oct 15, 2015 · 11 comments

Comments

@miltontony
Copy link
Contributor

The refactor on elasticsearch 1.8.0 affects the use of bulk_index in elasticutils

@miltontony miltontony changed the title Not compatible with elasticsearch>=2.0.0 Not compatible with elasticsearch>=1.8.0 Oct 15, 2015
@miltontony
Copy link
Contributor Author

Issue created with elasticutils mozilla/elasticutils#292

@infojunkie
Copy link

We'd love to try out elastic-git, but compatibility with latest ES is pretty important for our infrastructure. Is upgrading the codebase on your roadmap?

@smn
Copy link
Contributor

smn commented Mar 25, 2016

@infojunkie we'd love see it upgraded but it isn't a huge priority on our roadmap. The biggest issue is that Mozilla's elasticutils isn't being maintained anymore and that's a big dependency for us.

The work involved here is either taking over maintenance of elasticutils or swapping it out for an ES library that is maintained while (hopefully) maintaining backwards compatibility to some degree with our existing API. The latter is going to be quite difficult as our API relies heavily on elasticutils' API.

@infojunkie
Copy link

Yes, I noticed the tight coupling in the code. As far as ES python libs go, I would suggest Elastic's own elasticsearch-py as a base (https://github.com/elastic/elasticsearch-py), since it has good likelihood to remain maintained. Regarding minimizing rework, one approach could involve recreating the elasticutils API in an intermediate classlib, using the lower-level elasticsearch-py.

@infojunkie
Copy link

As we get more familiar with elastic-git, we might decide to use it in production and devote resources to the upgrade. We'll keep you updated here.

@smn
Copy link
Contributor

smn commented Mar 25, 2016

That'd be awesome!

Yes, it's entirely possible. Other than our own team's voluntary contributions, we have no projects currently driving this codebase and so it's not really possible for us to commit to it.

@webmaven
Copy link

webmaven commented Jul 3, 2016

Is this still an active issue?

@miltontony
Copy link
Contributor Author

@webmaven yes it is, we haven't upgraded it yet. But we're still using it in production with ES 1.7

@webmaven
Copy link

How about now? 😀

@smn
Copy link
Contributor

smn commented Oct 23, 2016

@webmaven we're very happy to accept code contributions but have no capacity to drive this ourselves and will likely not be a priority for us in the future either.

@smn smn mentioned this issue Nov 13, 2017
@jamessandy
Copy link

I want to contribute @webmaven

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants