Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A number of issues with AtomLists/AtomCollections #427

Open
lgarczyn opened this issue Aug 24, 2023 · 2 comments
Open

A number of issues with AtomLists/AtomCollections #427

lgarczyn opened this issue Aug 24, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@lgarczyn
Copy link

Bugs

  • "Propogate" instead of "Propagate" is present in both classes
  • "Type Mismatch" show in editor view of AtomList
    image

Incongruities with the rest of Atoms

  • No get-or-create event for Added / Removed / Cleared
  • No docs to explain the differences between AtomList and AtomValueList (with mentions of AtomBaseVariableList and AtomListWrapper)

Wishlist

  • Changed AtomBaseVariableEvent that allows to react to any change in the list
  • Possibility to extend AtomList or AtomCollection, to add features (all fields and utility functions are private)
  • Possibility to set a type filter on an AtomList (simply dropping a Bool var in the field to throw exception on any non-bool vars)
  • Possibility to set Syncer components to use OnEnable/OnDisable
@lgarczyn lgarczyn added the bug Something isn't working label Aug 24, 2023
@soraphis
Copy link
Collaborator

"Type Mismatch" show in editor view of AtomList

this isn't really a bug, but rather how unity renders scene references that cross scene borders (in this case to the SO)

No docs to explain the differences between AtomList and AtomValueList (with mentions of AtomBaseVariableList and AtomListWrapper)

There actually is this section:

Value Lists
A Value List is an array of values that is stored as a Scriptable Object.

Lists
A List is an array of Variables that is stored as a Scriptable Object. The Variables stored in a List can be of different types.
-- https://unity-atoms.github.io/unity-atoms/introduction/overview

@lgarczyn
Copy link
Author

this isn't really a bug, but rather how unity renders scene references that cross scene borders (in this case to the SO)

That's fine, but in that case there should be a custom field that renders, ideally, the value and name of the instancer. Similarly, normal variables should also display their value.

There actually is this section

Indeed, it appears that looking for unity atoms "ValueList" didn't point to the docs for some reason. Maybe the docs should include the csharp type names for better SEO ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants