feature: Added OnTagAdded and OnTagRemoved event handlers #415
Conversation
…t Reference Listener updated screenshot to match
|
please make yourself familiar with the https://github.com/unity-atoms/unity-atoms/blob/master/CONTRIBUTING.md pull requests should target the canary branch, not the master. |
…t Reference Listener updated screenshot to match
…y-atoms into ThaungThanHan
There was a problem hiding this comment.
Could you try to get rid of the changes in docs/assets/mono-hooks/listener.png and docs/tutorials/mono-hooks.md ?
I think they come from the fact, that you developed on master, instead of canary.
you can probably resolve that via
git checkout origin/canary -- docs/assets/mono-hooks/listener.png
git checkout origin/canary -- docs/tutorials/mono-hooks.md
this will revert the file to the state it has on the origin/canary.
| public AtomEventString OnTagAdded; | ||
| public AtomEventString OnTagRemoved; |
There was a problem hiding this comment.
Where does the AtomEventString type come from? I can't find it in the project.
It should be StringEvent, shouldn't it?
| @@ -172,6 +175,9 @@ public void AddTag(StringConstant tag) | |||
| // Update static accessors: | |||
| if (!TaggedGameObjects.ContainsKey(tag.Value)) TaggedGameObjects.Add(tag.Value, new List<GameObject>()); | |||
| TaggedGameObjects[tag.Value].Add(this.gameObject); | |||
|
|
|||
| // Start TagAdded event | |||
| TagAdded?.Invoke(tag.Value); | |||
There was a problem hiding this comment.
When using StringEvent, this will be Raise instead of Invoke.
Also StringEvent is a UnityEngine.Object type, so it must not be compared with ?. but instead using if(... == null) because the UnityEngine.Object == operator is overloaden and this is not taken into account when using ?. or is null
In this PR, I have added OnTagAdded and OnTagRemoved event handlers. Those two functions will fire whenever a tag is added or removed. In this procedure, I created a tagEventSubscriber script to connect the event listener to the AtomTags script in Tags package. Please review the code and feel free to pinpoint the area I am missing out on.
Fixes: #412