Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve contrast in TailSpin component #79

Open
frinyvonnick opened this issue Nov 2, 2017 · 3 comments
Open

Improve contrast in TailSpin component #79

frinyvonnick opened this issue Nov 2, 2017 · 3 comments
Assignees
@frinyvonnick
Labels
enhancement

Comments

@frinyvonnick
Copy link
Collaborator

No description provided.

@frinyvonnick frinyvonnick self-assigned this Nov 2, 2017
@frinyvonnick
Copy link
Collaborator Author

@fabienjuif it seems to work accordingly to this test. But on dark colors like black contrast is a bit light.

@frinyvonnick frinyvonnick changed the title Determine Loader component color recursively Improve contrast in TailSpin component Nov 2, 2017
@fabienjuif
Copy link
Member

We should detect if the retrieve background color is more light than dark, and then apply the appropriate color transformation from this.

@frinyvonnick
Copy link
Collaborator Author

I suggested to use getBrightness from tinycolor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frinyvonnick frinyvonnick

Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frinyvonnick @fabienjuif