Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why the load function is not forwarded to wrapped component ? #104

Open
EmrysMyrddin opened this issue Mar 11, 2019 · 1 comment
Open

Why the load function is not forwarded to wrapped component ? #104

EmrysMyrddin opened this issue Mar 11, 2019 · 1 comment

Comments

@EmrysMyrddin
Copy link

You have implemented getDerivedStateFromProps to avoid forward the load function. But why do you do that ? What problem are you trying to solve ?
@fabienjuif
Copy link
Member

At the times it felt cleaner not to inject useless props to the children.
load is an implementation detail that we didn't want the children to take care of, like for example, in its shoulComponentUpdate implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EmrysMyrddin @fabienjuif