Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all subscribers when doing rmpsp #245

Open
strong84 opened this issue Oct 13, 2019 · 3 comments
Open

Remove all subscribers when doing rmpsp #245

strong84 opened this issue Oct 13, 2019 · 3 comments

Comments

@strong84
Copy link

When remove a psp(rmpsp), should it also remove all the subscribers belongs to this psp?

In my uniqush push server, when I remove a psp, all the subscribers are remained.

@TysonAndre
Copy link
Contributor

It's currently not designed to remove all of the subscribers belonging to the psp. This feature would be nice to have (e.g. add ?purgesubscribers=1)

  • Making it opt-in would make sense, to avoid accidentally deleting subscribers when a user is trying to change an existing PSP.
  • Currently, uniqush-push does not require SCAN or KEYS for core functionality (except for listing all subscribers with wildcard operators). Some uniqush-push installations may use a proxy that forwards commands to multiple different redis instances, and SCAN/KEYS wouldn't be available for those proxies.
  • This will have common functionality with Write script to create a uniqush dump of PSPs and subscribers based on one or more rdb snapshots #191 - both require iterating over delivery points and associating them with subscriptions
  • The rate of deletion should be throttled to avoid impacting regular push notifications and other applications using the same redis instance. There should be a way to view progress and to cancel an in-progress task to remove all subscribers.

@strong84
Copy link
Author

strong84 commented Oct 14, 2019

Cool!

BTW, I notice the api document is not up to date on http://uniqush.org/documentation/usage.html
new features are buried in github release notes. this could lose track. and difficult for new user like me.

@strong84
Copy link
Author

BTW, I notice the api document is not up to date on http://uniqush.org/documentation/usage.html
new features are buried in github release notes. this could lose track. and difficult for new user like me.

Just discovered NEWS.md in the repo. all the changes are listed there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants