Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maxwell #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Maxwell #22

wants to merge 2 commits into from

Conversation

MaxSultan
Copy link

I decided to try to show a range of skills so I did everything from scratch (with the exception of using react) but ran out of time. I spent about 2 hours on this. Setting up a react app without a pre-made toolchain took me a lot more time that I expected. I have never had to create an app from scratch without create-react-app or the vue-cli. Since this was a carousel, I wanted to make sure we preserved aspect size across the whole range of devices and that the carousel was mobile responsive.

Some learning opportunities this created:

  • preloading images (do I need to do this if images are local assets)
  • writing react without JSX
  • Setting up a react app without create-react-app

If I had additional time I would:

  • animate the transition of images (forward, backwards, and edge case where go from image 0 to 7 or the reverse)
  • add an auto transition so the images scroll on their own
  • decide design wise where text would be best displayed and add it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant