New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Vec
yokeable
#4789
Labels
C-zerovec
Component: Yoke, ZeroVec, DataBake
Comments
It seems intuitive that the items of a |
This would be acceptable, I think. |
Though I think the reason we have that impl is because doing such impls on third-party crates can be annoying. But we don't care too much about Vec in ICU4X so we're not relying on it anyway. I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Yokeable
is implemented forVec
, but it does not forward the yoking and instead just treat them as owned values that do not borrow from the cart. This is inconsistent with the implementation ofYokeable
for arrays, which does forward to the items.I don't see any inherent reason why
Vec
couldn't do the same. This is a breaking change, but with the current situation it is impossible (safely) to useVec
as a yokeable, while if we change it it is easily possible to restore the old behavior by derivingYokeable
on non-yoked structs.The text was updated successfully, but these errors were encountered: