Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reliance on archived project partial-min-max #4764

Open
SimonClark opened this issue Apr 1, 2024 · 1 comment
Open

Reliance on archived project partial-min-max #4764

SimonClark opened this issue Apr 1, 2024 · 1 comment
Labels
S-small Size: One afternoon (small bug fix or enhancement) T-techdebt Type: ICU4X code health and tech debt

Comments

@SimonClark
Copy link

In going through my org's security review, a concern was raised over the reliance of utils/bies on the partial-min-max crate. https://github.com/fitzgen/fart/tree/master does not have a well formed license, and has been archived.

Any chance we can remove this as a dependency? Would it be most expeditious for me to submit an MR to do that?

@sffc
Copy link
Member

sffc commented Apr 2, 2024

Hi! Happy to entertain a pull request to remove the dependency. Note that the bies util crate is not currently a dependency of icu4x library code, but it might be in the future.

@sffc sffc added T-techdebt Type: ICU4X code health and tech debt S-small Size: One afternoon (small bug fix or enhancement) labels Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-small Size: One afternoon (small bug fix or enhancement) T-techdebt Type: ICU4X code health and tech debt
Projects
None yet
Development

No branches or pull requests

2 participants