Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clouddriver - consider using cloudProvider metric #1

Open
karlskewes opened this issue Jun 16, 2021 · 0 comments
Open

Clouddriver - consider using cloudProvider metric #1

karlskewes opened this issue Jun 16, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@karlskewes
Copy link
Collaborator

Per upstream PR available in 1.25.x: https://github.com/spinnaker/clouddriver/pull/5252/files

This might:

  • simplify metric queries with regex matching label serviceEndpoint=~".*$AwsRegion.*" in both clouddriver.jsonnet and spinnaker-aws-platform.jsonnet, other?
  • be suitable in a key metrics section of clouddriver.jsonnet showing per cloudProvider RED or just errors.

Examples:

  • before:
    orchestrations_seconds_count{cloudProvider="kubernetes", container="clouddriver", <snip>}
    
  • after:
    orchestrations_seconds_count{container="clouddriver", <snip>}
    
@karlskewes karlskewes added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant