Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft for design cleanup in join page #425

Closed
wants to merge 2 commits into from
Closed

Draft for design cleanup in join page #425

wants to merge 2 commits into from

Conversation

akshatarora130
Copy link
Contributor

@akshatarora130 akshatarora130 commented May 6, 2024 •
edited

What does this PR do?

Design cleanup for Signup: Username form

Fixes #405

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Required

  • Read Contributing Guide
  • Self-reviewed my own code
  • Tested my code in a local environment
  • Commented on my code in hard-to-understand areas
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR

@akshatarora130 akshatarora130 marked this pull request as ready for review May 6, 2024 12:32
@akshatarora130
Copy link
Contributor Author

Screenshot 2024-05-06 at 17 59 31

@graphite-app Graphite App
Copy link

graphite-app bot commented May 6, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (05/06/24)

1 assignee was added to this PR based on Rahul Mishra's automation.

@McPizza0
Copy link
Member

McPizza0 commented May 7, 2024

@akshatarora130
I should have clarified; we actually have a whole new design for the signup pages that we'll be implementing
no need to spend energy here right now

appreciate the effort though

@McPizza0 McPizza0 closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McPizza0 McPizza0 Awaiting requested review from McPizza0 McPizza0 is a code owner

Assignees

@akshatarora130 akshatarora130

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate(react/next): Signup: Username Form
2 participants
@akshatarora130 @McPizza0