-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make github.com/umputun/reproxy/lib a submodule #117
Comments
this is a valid concern. Making submodule in go is smth awkward a little bit with an additional tag we will have to maintain for lib. However, breaking dependency to the I'm not sure I understand the meaning of "will have to be vendored" item. Does it mean vendored by reproxy itself because it will be treated as a module and won't be resolvable "directly" anymore? Are you saying this won't work anymore unless vendored? |
Yes, you are right. From golang/go#33789:
Some workarounds:
But as I said, |
Import of
github.com/umputun/reproxy/lib
addsgithub.com/umputun/reproxy
togo.mod
. It results in a significant number of dependencies.At the same time,
github.com/umputun/reproxy/lib
requires only 3 dependencies:github.com/go-pkgz/lgr
github.com/go-pkgz/repeater
github.com/stretchr/testify
Making
github.com/umputun/reproxy/lib
a submodule can resolve this issue.However, this change will also require some additional work:
vX.Y.Z
forgithub.com/umputun/reproxy
andlib/vX.Y.Z
forgithub.com/umputun/reproxy/lib
github.com/umputun/reproxy/lib
will have to be vendored (see cmd/go: allow 'go mod vendor' to omit replaced modules golang/go#33789 and build: no longer use vendor directory hashicorp/nomad#10898)github.com/umputun/reproxy/lib
will have to update dependency path and versionI don't think these points are very critical: API of
github.com/umputun/reproxy/lib
is pretty stable, and the current version (v0.10.0
) allows to make breaking changesThe text was updated successfully, but these errors were encountered: