Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v15: TipTap media picker issues #18020

Open
PhyxionNL opened this issue Jan 17, 2025 · 1 comment
Open

v15: TipTap media picker issues #18020

PhyxionNL opened this issue Jan 17, 2025 · 1 comment
Assignees
Labels
affected/v15 state/needs-investigation This requires input from HQ or community to proceed type/bug

Comments

@PhyxionNL
Copy link
Contributor

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.1.1

Bug summary

The URLs the media picker from TipTap generates the img src like this:

http://domain/media/htufswhc/test.png?width=930&height=625&mode=Max

Several issues:

  • For some reason it insists on adding the domain, which it probably shouldn't (not happening with TinyMCE).
  • I have HMAC enabled in ImageSharp and HMAC isn't added.

TinyMCE just adds the base URL, here: media/htufswhc/test.png, without parameters as what's generated is the image size.

Specifics

No response

Steps to reproduce

See above.

Expected result / actual result

No response

Copy link

Hi there @PhyxionNL!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@leekelleher leekelleher self-assigned this Jan 21, 2025
@leekelleher leekelleher added state/needs-investigation This requires input from HQ or community to proceed affected/v15 labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected/v15 state/needs-investigation This requires input from HQ or community to proceed type/bug
Projects
None yet
Development

No branches or pull requests

2 participants