Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block list content can be updated when the hide content editor is enabled #17835

Open
nhudinh0309 opened this issue Dec 18, 2024 · 2 comments
Open

Comments

@nhudinh0309
Copy link
Contributor

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.2.0-rc

Bug summary

The user still can update block list content although the hide content editor is enabled

Specifics

No response

Steps to reproduce

  1. Create a document type with block list editor
  2. Define a block element for the block list with the hide content editor is enabled
  3. Enable the setting "Inline editing mode" of the block list editor
  4. Create a content with a block list

Expected result / actual result

Expected result:
User should not be able to update the block content
Actual result:
User can update the block content

BlockListIssue_AbleToUpdateContent.mp4
@nielslyngsoe
Copy link
Member

Hi @nhudinh0309 this is the same experience as in v.13

It is surely a quirky situation to end up in, and I think the right solution to this would be communication (better description of the configuration field)

Here is the explanation:
The Hide content editor is specific towards the content editor of the Block Modal (and as well hides the edit button on the Block)
This is useful if you have own Custom View that brings a editorial UI. Then you do not want to have the same fields available in the Block Modal.
When turning on Inline Editing, then it behind the scenes sets Hide content editor to true, as you now only can edit via the interface directly on the Block (Similar to a Custom View with an Editorial Interface)

I hope that makes sense, we a Field Description could be enough to fix the misunderstanding?

@nielslyngsoe
Copy link
Member

Ive set this issue as Up-for-graps if you like to improve this case, feel free to make sure that this misunderstanding is less likely.
First idea is to append a description to the hide content editor field.
Additionally the field could become disabled and set to true when Inline Editing is set to true. Ideally with a text describing why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants