Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at #4579 if you get the chance. That pull request uses memo instead of a ref and also eliminates the double initialization that also causes issues (build failure). Best not to create the editor instance in an effect, but a memo instead; that way it gets created first render and after any deps array changes. The above PR also fixes the memory leak with the existing ref-based hook. Not a big deal to me either way if you want to just merge this PR in and abandon/close mine, but I would definitely recommend using memo. I am curious though if the types will be updated in a breaking change later, for those that extend the hook using Typescript or have ESLint rules for unnecessary null checks.
Also heads up, this is also similar to this draft PR https://github.com/ueberdosis/tiptap/pull/4858/files by @svenadlung , which has the same issue of double editor initialization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls 🙏 @bdbch @svenadlung