From 76d7f19afd215120ee08049c524f52feff3dc777 Mon Sep 17 00:00:00 2001
From: Nicholas Wiltsie <nwiltsie@mednet.ucla.edu>
Date: Wed, 4 Sep 2024 10:01:02 -0700
Subject: [PATCH] Catch failing test cases

---
 CHANGELOG.md         | 5 +++++
 nftest/NFTestCase.py | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index fc0eb04..809892d 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,11 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 
 ---
 
+## [Unreleased]
+
+### Fixed
+- Properly catch failing test cases
+
 ## [1.1.0] - 2024-07-08
 
 ### Added
diff --git a/nftest/NFTestCase.py b/nftest/NFTestCase.py
index 6a665e3..a1491af 100644
--- a/nftest/NFTestCase.py
+++ b/nftest/NFTestCase.py
@@ -103,8 +103,8 @@ def test(self) -> bool:
             self._logger.info(" [ skipped ]")
             return True
 
-        nextflow_succeeded = self.submit()
-        if not nextflow_succeeded:
+        nextflow_process = self.submit()
+        if nextflow_process.returncode != 0:
             self._logger.error(" [ failed ]")
             return False