Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant imagetype argument #24

Open
stefaneng opened this issue Jan 12, 2023 · 1 comment
Open

Redundant imagetype argument #24

stefaneng opened this issue Jan 12, 2023 · 1 comment

Comments

@stefaneng
Copy link
Contributor

If filename is specified with an extension then imagetype parameter should be inferred automatically.

Two solutions:

  1. Leaving both arguments in I propose that we:
    a. First look for extension in filename
    b. If no extension then find extension from imagetype
  2. Deprecate imagetype argument and only access filetype via extension given in filename

Current we can create a tiff file with a pdf extension without any kind of warning:

venn.diagram(
	x = list(A = 1:150, B = 121:170),
	filename = 'test.pdf',
	imagetype = 'tiff',
	disable.logging = TRUE
	)
@pboutros
Copy link
Collaborator

Yup makes sense to deprecate imagetype, and potentially to import the write.plot function that's in BPG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants