Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivated Extensions Cannot be Reactivated #38

Open
Thetwam opened this issue May 11, 2020 · 0 comments
Open

Deactivated Extensions Cannot be Reactivated #38

Thetwam opened this issue May 11, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@Thetwam
Copy link
Member

Thetwam commented May 11, 2020

Describe the bug

Once an extension has been set as inactive (active field is set to 0), there is no path for it to become active again, short of manually editing the database. This also happens without being fully transparent to the person running Quiz Extensions that a user's extension is being actively ignored.

To Reproduce

Steps to reproduce the behavior:

  1. Create a new extension for a user via the usual Quiz Extensions process.
  2. Go to the extension table in the database and find the new extension entry.
  3. Observe that the active field is set to 1.
  4. Cause the user to be in a state that will mark them as inactive: remove them from the course, change their enrollment type to something other than "student", or change their enrollment state to something other than "active" or invited".
  5. Run the update process
  6. Observe that the active field is set to 0.
  7. Put the user back into a stable state: enrolled in the course as type "student" and status "active" or "invited".
  8. Create a new extension for the user via the usual Quiz Extensions process. This updates the existing extension record instead of creating a new one.
  9. Observe that (despite the user now being enrolled properly) the active field is still set to 0.

Expected behavior

When the update process is run, it should check whether or not users with inactive extensions have changed into an active state, instead of just ignoring them.

Note: This will have some minor performance hits, but will be part of the backgrounded process.

Also need to improve feedback to user to explain that x users are being ignored due to being inactive.

Environment information

  • Python version (python --version): any
@Thetwam Thetwam added the bug Something isn't working label May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant