-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUI: recovery shows "Installling update" when doing a factory reset #18
Comments
And a progress bar please ^^ |
Will contact you next week regarding mockups :) |
Luckily at least LOS recovery 5.1/7.1/9.0 has a progress bar already included, but we do not use it since our script runs as external process and cannot report back into the C code. I think that can be fixed somehow =) |
Yes, it can. We need to define steps to report and add some callbacks to update UI state. As we can not really report percentages of the update progress i think it would be best to show an indeterminated progress bar and update text according to what is happening? Then we can reuse the current yumi animation we have and just update the text. |
Yeah the old 5.1 recovery uses "indeterminate" mode already, below Yumi there are 3 orange dots moving around... But I think we lost that over time and the many recovery changes LOS has done. And yes, a text update facility would be great |
When issuing a factory reset from the system, it will reboot to recovery to, well, factory reset the device.
To do so, it will write to
/cache/recovery/ubuntu_command
and trigger/sbin/system-image-upgrader
.Currently there is no way to check what we are actually doing and even if not installing an OTA and just formatting data, it will show "Installing update".
We should smarten up the
system-image-upgrader
specific code and better represent the UI states.The text was updated successfully, but these errors were encountered: