-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: switch to official upstream images #687
base: main
Are you sure you want to change the base?
Conversation
.github/workflows/reusable-build.yml
Outdated
- image_name: sericea | ||
base_image: quay.io/fedora/fedora-sway-atomic | ||
- image_name: onyx | ||
base_image: quay.io/fedora/fedora-budgie-atomic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just go with the upstream names so they end up being sway-main
and budgie-main
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do, though it may be best waiting for the next major version rather than introducing breaking changes in the middle of a cycle
I see |
What about |
fedora-bootc is extremely minimal. I'd probably say too minimal for us at this time. Not saying we'll never switch over to fedora-bootc for the base images. But it'll need a lot more tweaking and testing than I'm able to provide right now. Hopefully Timothee will support a fedora-base-atomic image we can inherit |
But the official quay image contains |
Closes #669
This is fully backwards-compatible. Builds official images using the official Quay repository, but keeps building the unofficial images using the unofficial repository.
I have tested this with a Fedora 41 image, which worked exactly the same as before. I haven't tested with Fedora 40.