revert: "feat: set Recommends=false by default to minimize local layer size" #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I actually saw the discussion for ublue-os/main#632 as I was trying to get back to "normal" after holiday... I was going to chime but it merged before I could. I really did not understand the logic of merging this when it didn't help with image, but only in some instances provided value for users doing local layering ... which, which we kinda advise them not to do. So I support reverting, especially if it's been reported to cause user pain. |
bsherman
approved these changes
Aug 25, 2024
KyleGospo
approved these changes
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes issues with people in chat "I added this package and it didn't bring libvirt" etc.
In hindsight let's back this out, there's no reason to deviate from fedora on this one.