Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snapper): fix invalid config and remove incorrect snapshots #1941

Closed
wants to merge 4 commits into from

Conversation

HikariKnight
Copy link
Member

for some users the snapper-timeline.timer has been enabled out of the blue, it is not enabled by default (it is off on a new install and on my legion go)

Also somehow the config we made in the repository is not even added to the final image, so everyone has a default config where the timeline retention is 10 years of snapshots, this did not happen during the months of testing i did.

This will correct the config by setting all snapshot retention values to 0 so the user HAS to make a changes themselves for snapper to work (this was the idea from the beginning but somehow the snapper-timeline timer gets enabled and we do not know how)
and adds a safeguard against it and deletes all incorrectly taken snapshots
The same safeguard is applied to snapper-boot.timer

This PR is in conflict with #1939 and it way less nuclear and achieves the same thing.
I do not mind which PR is chosen, main point is we have 2 options to fix the issue.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Dec 2, 2024
@Zeglius
Copy link
Contributor

Zeglius commented Dec 4, 2024

You still need some way to start the script to apply the new config on already affected devices, maybe an oneshot service that disables itself afterwards or calling it at bazzite-hardware script

@HikariKnight
Copy link
Member Author

You still need some way to start the script to apply the new config on already affected devices, maybe an oneshot service that disables itself afterwards or calling it at bazzite-hardware script

bazzite-snapper-setup runs at startup

@HikariKnight HikariKnight deleted the snapper-fixes branch December 7, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants