fix(snapper): fix invalid config and remove incorrect snapshots #1941
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for some users the
snapper-timeline.timer
has been enabled out of the blue, it is not enabled by default (it is off on a new install and on my legion go)Also somehow the config we made in the repository is not even added to the final image, so everyone has a default config where the timeline retention is 10 years of snapshots, this did not happen during the months of testing i did.
This will correct the config by setting all snapshot retention values to
0
so the user HAS to make a changes themselves for snapper to work (this was the idea from the beginning but somehow the snapper-timeline timer gets enabled and we do not know how)and adds a safeguard against it and deletes all incorrectly taken snapshots
The same safeguard is applied to
snapper-boot.timer
This PR is in conflict with #1939 and it way less nuclear and achieves the same thing.
I do not mind which PR is chosen, main point is we have 2 options to fix the issue.