Skip to content

Commit

Permalink
fix: fixup build action signing (#1828)
Browse files Browse the repository at this point in the history
* fix: move tag to inner for loop to avoid var being blank

* chore: remove unused outputs step
  • Loading branch information
antheas authored Oct 31, 2024
1 parent 8b86bf3 commit eef3b81
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -391,9 +391,9 @@ jobs:
echo "${{ secrets.GITHUB_TOKEN }}" | sudo podman login ghcr.io -u ${{ github.actor }} --password-stdin
for tag in ${{ steps.generate-tags.outputs.alias_tags }}; do
sudo skopeo copy ${{ steps.rechunk.outputs.ref }} docker://${{ steps.registry_case.outputs.lowercase }}/${{ env.IMAGE_NAME }}:$tag
# Keep one tag for signing
echo "sign_tag=$tag" >> $GITHUB_OUTPUT
done
# Keep one tag for signing
echo "sign_tag=$tag" >> $GITHUB_OUTPUT
- name: Sign container image
uses: EyeCantCU/cosign-action/[email protected]
Expand All @@ -404,11 +404,6 @@ jobs:
signing-secret: ${{ secrets.SIGNING_SECRET }}
tags: ${{ steps.push.outputs.sign_tag }}

- name: Echo outputs
if: github.event_name != 'pull_request'
run: |
echo "${{ toJSON(steps.push.outputs) }}"
generate_release:
name: Generate Release
needs: [push-ghcr]
Expand Down

0 comments on commit eef3b81

Please sign in to comment.