Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment rules allow possibly invalid invocations #404

Open
jamesreprise opened this issue Mar 6, 2024 · 0 comments
Open

Deployment rules allow possibly invalid invocations #404

jamesreprise opened this issue Mar 6, 2024 · 0 comments

Comments

@jamesreprise
Copy link
Contributor

jamesreprise commented Mar 6, 2024

Problem

We have a pattern of requiring the specification of 'snapshot' and 'release' repositories for deployment rules. This is true for the following.

  • deploy_apt
  • deploy_brew
  • deploy_crate
  • deploy_npm
  • deploy_maven
  • deploy_pip
  • deploy_helm

This is troublesome when we want to have a target using this rule point to another target that is specifically a 'snapshot' or 'release' artefact as we've now introduced the possibility of an invalid invocation; our deployment target can make a 'release' deployment for a 'snapshot' artefact or vice versa.

Suggestion

Instead of requiring the specification of both 'snapshot' and 'release' repositories we could require that just one 'repository' is specified. This allows us to create multiple targets (manually or through macros, list comprehensions) for our desired workflows.

@jamesreprise jamesreprise self-assigned this Mar 6, 2024
@jamesreprise jamesreprise changed the title Refactor 'snapshot' and 'release' into 'repository' in deployment rules Deployment rules allow possibly invalid invocations Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant