Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: Add better label to section video play buttons #226

Open
twostraws opened this issue Sep 27, 2021 · 0 comments
Open

Accessibility: Add better label to section video play buttons #226

twostraws opened this issue Sep 27, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@twostraws
Copy link
Owner

From a user: "There is a “link” that plays the video for the section, but from an accessibility point of view all that is spoken is “link”. Could you consider adding a label like “Play Video” so that the Voiceover speaks “Play Video link”. "
@twostraws twostraws added the good first issue Good for newcomers label Sep 27, 2021
gvmrtnv added a commit to gvmrtnv/Unwrap that referenced this issue Dec 25, 2021
@gvmrtnv
Accessibility: Add better label to section video play buttons
08d594e 
I've added label "Play Video" to Chapter's Video, so that the VoiceOver speaks "Play Video Link"

Adresses twostraws#226

Unfortunately native HTML-solutions for screen-readers tags don't work here(tried many). So finally i've added 1px high text to link.
@gvmrtnv gvmrtnv mentioned this issue Dec 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@twostraws