Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP_PROXY et al. Environment Vars Not Supported #232

Open
0cjs opened this issue Jan 24, 2019 · 3 comments
Open

HTTP_PROXY et al. Environment Vars Not Supported #232

0cjs opened this issue Jan 24, 2019 · 3 comments

Comments

@0cjs
Copy link

0cjs commented Jan 24, 2019

Unlike requests, treq doesn't support the (semi-standard) environment variables for proxy configuration, such as HTTP_PROXY, https_proxy, no_proxy and others. This makes it unusable in some applications, such on company networks that do not allow direct Internet access.

This is a separate concern from issue #174 and corresponding PR #130: those appear to talk about/provide only programatic proxy support, which would still require users running third-party code that uses treq to change that third-party code if they must use a proxy. (That said, integrating PR #130 would still be helpful to me in some situations, so I'd still encourage integrating it ASAP.)

@0cjs
Copy link
Author

0cjs commented Jan 24, 2019

Oh, just in case whomever might work on this is not aware, requests uses urllib.requests.getproxies() to retrive proxy information from the environment (including MacOS X system configuration and the Windows registry, where applicable), so that's what should be used here, too, though there's still further processing required for no_proxy and perhaps all_proxy and other things.

@glyph
Copy link
Member

glyph commented Feb 19, 2019

This would be handy!

@aigr
Copy link

aigr commented Apr 15, 2019

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants