Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Documentable.expandName #125

Closed
adiroiban opened this issue Aug 3, 2016 · 1 comment · May be fixed by #414
Closed

Document Documentable.expandName #125

adiroiban opened this issue Aug 3, 2016 · 1 comment · May be fixed by #414

Comments

@adiroiban
Copy link
Member

The expandName() docstring say it returns a fully qualified name, but I can also see that at least for interface references, it is not returning FQN.

For example in the context of twisted.web.client.Response._construct expandName('IResponse.request') -> 'request'

We need a set of automated tests to help understand what this code should do and to review the docstring.
This was referenced Aug 3, 2016
Open
Merged
@tristanlatr
Copy link
Contributor

I feel like this issue has been fixed.

At least for the docstring part, it's quite clear now.
I've added a few details in #414.

Screen Shot 2021-06-26 at 8 31 24 PM

Maybe there is still an issue with interfaces, I've not added special tests for that.

@tristanlatr tristanlatr linked a pull request Jan 1, 2022 that will close this issue
Document and follow aliases better #414
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document and follow aliases better tristanlatr/pydoctor
2 participants
@adiroiban @tristanlatr