Mm/proposal procedures #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florentc
requested changes
Jun 26, 2024
There was a problem hiding this comment.
Nice!! It is always satisfying to see how new features integrate well in the codebase. Also, I like the simplification of the redeemer api.
- Changes to the API need to be applied to the CHEATSHEET.
- The CHANGELOG should be updated as well.
- I think splitting GenerateTx into several submodules and the documentation phase unrelated to proposal procedures should have been in another PR to ease focus during the review process. I did not review the generatetx submodules that are from previous code. I reviewed the new content though.
Co-authored-by: Florent C. <[email protected]>
…dators into mm/proposal-procedures
florentc
reviewed
Jun 27, 2024
Comment on lines
+540
to
+547
| simpleTxSkelProposal :: (ToAddress a) => a -> TxGovAction -> TxSkelProposal | ||
| simpleTxSkelProposal a govAction = TxSkelProposal (toAddress a) govAction Nothing Nothing | ||
|
|
||
| withWitness :: (ToScript a) => TxSkelProposal -> (a, TxSkelRedeemer) -> TxSkelProposal | ||
| withWitness prop (s, red) = prop {txSkelProposalWitness = Just (toScript s, red)} | ||
|
|
||
| withAnchor :: TxSkelProposal -> String -> TxSkelProposal | ||
| withAnchor prop url = prop {txSkelProposalAnchor = Just url} |
There was a problem hiding this comment.
Since a lot of datatypes in Skeleton already use existential types. Could we maybe do that with TxSkelProposal and replace its Api.Address with a where a has the ToAddress constraint? We would get the conversion for free without the need for simpleTxSkelProposal.
florentc
reviewed
Jun 27, 2024
added 2 commits
June 28, 2024 01:51
florentc
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add the core elements of proposal procedures feature to cooked-validators.
This also closes #419.