Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot focus email more button "..." on mobile screen readers #8183

Open
10 tasks
hrb-hub opened this issue Dec 23, 2024 · 0 comments · Fixed by #8196
Open
10 tasks

Cannot focus email more button "..." on mobile screen readers #8183

hrb-hub opened this issue Dec 23, 2024 · 0 comments · Fixed by #8196
Assignees
@hrb-hub
Labels
a11y Accessibility related problems bug broken functionality, usability problems, unexpected errors

Comments

@hrb-hub
Copy link
Contributor

hrb-hub commented Dec 23, 2024 •
edited
Loading

Describe the bug
When using a mobile screen reader the email "more actions" button cannot be focused

To Reproduce

  1. In mail details view, using TalkBack keep selecting next item until you go past the mail's "more actions" button.
  2. See that it does not get focused.

Expected behavior
We should be able to focus the mail's "more actions" button on mobile screen readers.

Screenshots
Image

Test notes

  • Using TalkBack
    • "more actions" button can be focused and clicked
    • Mail sender text can be:
      • Focused
      • Clicked to expand and collapse mail
  • Tabbing using a keyboard
    • "more actions" button can be focused and clicked
    • Mail sender text can be:
      • Focused
      • Clicked to expand and collapse mail
@hrb-hub hrb-hub added bug broken functionality, usability problems, unexpected errors a11y Accessibility related problems labels Dec 23, 2024
@hrb-hub hrb-hub self-assigned this Dec 23, 2024
hrb-hub added a commit that referenced this issue Dec 24, 2024
@hrb-hub
Fix cannot focus mail more button on mobile screen readers
a6b555e 
The issue was caused by the more button having a parent element with a
`role="button"` resulting in the more button having a role of
"presentation".

To fix this, click handling was moved to a more button's sibling element
(mail sender text).

Close #8183
@hrb-hub hrb-hub mentioned this issue Dec 24, 2024
Merged
@hrb-hub hrb-hub linked a pull request Dec 24, 2024 that will close this issue
Fix cannot focus mail more button on mobile screen readers #8196
Merged
hrb-hub added a commit that referenced this issue Jan 2, 2025
@hrb-hub
Fix cannot focus mail more button on mobile screen readers
ca6b42f 
The issue was caused by the more button having a parent element with a
`role="button"` resulting in the more button having a role of
"presentation".

To fix this, click handling was moved to a more button's sibling element
(mail sender text).

Close #8183
hrb-hub added a commit that referenced this issue Jan 2, 2025
@hrb-hub
Fix cannot focus mail more button on mobile screen readers
1a1c922 
The issue was caused by the more button having a parent element with a
`role="button"` resulting in the more button having a role of
"presentation".

To fix this, click handling was moved to a more button's sibling element
(mail sender text).

Close #8183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hrb-hub hrb-hub

Labels
a11y Accessibility related problems bug broken functionality, usability problems, unexpected errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix cannot focus mail more button on mobile screen readers tutao/tutanota
1 participant
@hrb-hub