Handle mail export throttling #8118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlag
reviewed
Dec 12, 2024
| @@ -127,8 +126,19 @@ export class MailExportController { | |||
|
|
|||
| private async runExport(mailboxDetail: MailboxDetail, mailBags: MailBag[], mailId: Id) { | |||
| for (const mailBag of mailBags) { | |||
| await this.exportMailBag(mailBag, mailId) | |||
| if (this._state().type !== "exporting") { | |||
| try { | |||
There was a problem hiding this comment.
does this mean that if we get one of the errors the export aborts? I thought we would wait however long is necessary and then continue
BijinDev
force-pushed
the
8109-throttle-handling
branch
2 times, most recently
from
86160d9 to
2c0d66d
Compare
charlag
approved these changes
Dec 16, 2024
paw-hub
force-pushed
the
8109-throttle-handling
branch
3 times, most recently
from
9a68975 to
6a55f9e
Compare
issue #8109 Co-authored-by: paw <[email protected]>
paw-hub
force-pushed
the
8109-throttle-handling
branch
from
6a55f9e to
41933f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #8109