Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add table aws_iot_* #1994

Closed
jolo-dev opened this issue Dec 4, 2023 · 5 comments · Fixed by #1997, #1998, #1999 or #2000 · May be fixed by #2002
Closed

Add table aws_iot_* #1994

jolo-dev opened this issue Dec 4, 2023 · 5 comments · Fixed by #1997, #1998, #1999 or #2000 · May be fixed by #2002
Assignees
@ParthaI
Labels
enhancement New feature or request new table New table request

Comments

@jolo-dev
Copy link

jolo-dev commented Dec 4, 2023

Add new tables (plural!!)

  • aws_iot_core_things
  • aws_iot_core_thing_groups
  • aws_iot_core_thing_types
  • aws_iot_core_fleet_metrics
  • aws_iot_greengrass_devices
  • aws_iot_greengrass_components
  • aws_iot_greengrass_deployments
  • aws_iot_greengrass_devices
  • aws_iot_greengrass_groups

References
AWS IoT Core
AWS IoT Greengrass
@jolo-dev jolo-dev added enhancement New feature or request new table New table request labels Dec 4, 2023
@ParthaI
Copy link
Contributor

ParthaI commented Dec 4, 2023 •
edited

Thank you, @jolo-dev, for bringing this issue to our attention and for your interest towards Steampipe. We will take a look into it.

@ParthaI ParthaI self-assigned this Dec 4, 2023
ParthaI added a commit that referenced this issue Dec 5, 2023
@ParthaI
Add table aws_iot_thing Closes #1994
090cff3
@ParthaI ParthaI linked a pull request Dec 5, 2023 that will close this issue
Add table aws_iot_thing Closes #1994 #1997
Merged
ParthaI added a commit that referenced this issue Dec 5, 2023
@ParthaI
Add table aws_iot_thing_group Closes #1994
dcf72bb
@ParthaI ParthaI linked a pull request Dec 5, 2023 that will close this issue
Add table aws_iot_thing_group Closes #1994 #1998
Merged
ParthaI added a commit that referenced this issue Dec 6, 2023
@ParthaI
Add table aws_iot_thing_type Closes #1994
8549c2c
@ParthaI ParthaI linked a pull request Dec 6, 2023 that will close this issue
Add table aws_iot_thing_type Closes #1994 #1999
Merged
ParthaI added a commit that referenced this issue Dec 6, 2023
@ParthaI
Add table aws_iot_fleet_metric Closes #1994
b40b7e9
@ParthaI ParthaI linked a pull request Dec 6, 2023 that will close this issue
Add table aws_iot_fleet_metric Closes #1994 #2000
Merged
ParthaI added a commit that referenced this issue Dec 6, 2023
@ParthaI
Add table aws_iot_greengrass_* Closes #1994
b7d15c7
@ParthaI ParthaI linked a pull request Dec 6, 2023 that will close this issue
Add table aws_iot_greengrass_* Closes #1994 #2002
Open
@ParthaI
Copy link
Contributor

ParthaI commented Dec 7, 2023

@jolo-dev, I have raised the PR for the tables aws_iot_thing, aws_iot_thing_type, aws_iot_thing_group, aws_iot_greengrass_component, aws_iot_greengrass_core_device, and aws_iot_greengrass_deployment. It would be great if you could give it a try and share your feedback with us.

  • For querying the tables aws_iot_thing, aws_iot_thing_type, and aws_iot_thing_group, we need to merge the pr branches(issue-1994, add-table-iot-thing-type, and add-table-iot-thing-group) into a single branch, because there is a dependency between the PRs.
  • For querying the tables aws_iot_greengrass_* you can use the branch add-table-iot-greegrass.

Steps for testing out the tables:

  • git clone https://github.com/turbot/steampipe-plugin-aws.git
  • cd steampipe-plugin-aws
  • git checkout add-table-iot-greegrass if you want to test the aws_iot_greengrass_* tables and create a separate branch(git checkout -b my-test-branch) and pull the code changes from the branches issue-1994, add-table-iot-thing-type, and add-table-iot-thing-group.
  • make
  • Run the Query

Thanks!

@jolo-dev
Copy link
Author

jolo-dev commented Dec 7, 2023 •
edited

Hi @ParthaI,
Thanks for the contribution :)
It looks good for greengrass :)
Let me check with another aws account with more devices
In your PR, tests are missing.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale No recent activity has been detected on this issue/PR and it will be closed label Feb 5, 2024
@jolo-dev
Copy link
Author

jolo-dev commented Feb 6, 2024

Oh, I totally forgot about that.

@github-actions github-actions bot removed the stale No recent activity has been detected on this issue/PR and it will be closed label Feb 6, 2024
misraved pushed a commit that referenced this issue Feb 12, 2024
@ParthaI @khushboo9024
Add table aws_iot_thing Closes #1994 (#1997)
220654c 
Co-authored-by: Khushboo <[email protected]>
bigdatasourav pushed a commit that referenced this issue Apr 16, 2024
@ParthaI @khushboo9024
Add table aws_iot_fleet_metric Closes #1994 (#2000)
e05baf4 
Co-authored-by: Khushboo <[email protected]>
bigdatasourav pushed a commit that referenced this issue Apr 29, 2024
@ParthaI
Add table aws_iot_thing_type Closes #1994 (#1999)
0dfa4d1
bigdatasourav pushed a commit that referenced this issue Apr 29, 2024
@ParthaI
Add table aws_iot_thing_group Closes #1994 (#1998)
8086570
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ParthaI ParthaI

Labels
enhancement New feature or request new table New table request
Projects
None yet
Milestone
No milestone
2 participants
@ParthaI @jolo-dev