Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A single vote button doesn't load sometimes. #75

Open
7db9a opened this issue Sep 7, 2023 · 3 comments
Open

A single vote button doesn't load sometimes. #75

7db9a opened this issue Sep 7, 2023 · 3 comments
Assignees

Comments

@7db9a
Copy link
Member

7db9a commented Sep 7, 2023

A single vote button doesn't load sometimes. My focus is on feature/cypress-testing.

Based on gpt conversations, there is an issue in that a tsrcPRvoteStatus is set to 'new' when this happens. It throws and exception as buttonStyle doesn't have a field for 'new'.

I attempted to force it to 'vote' and 'lightgreen' when it threw such an error, but it only cosmetically solved the issue. Voting on the button that errored was disabled as a result.

@ramirc5
Copy link

ramirc5 commented Sep 7, 2023

turbo-src/turbosrc-engine#13
See above pull request, it should fix this issue.

@7db9a
Copy link
Member Author

7db9a commented Sep 8, 2023

That should do it. Thanks

@jex441
Copy link

jex441 commented Sep 13, 2023

I'm concerned that changing the state on the back end is causing issues elsewhere where it expects a 'new' state. The extension won't load now because its expecting a state value 'new' but is getting 'vote'.

I think we should reverse this change and fix it on the front end where the issue was occurring rather than on the back end where it will have unintended consequences elsewhere.

@ramirc5 @7db9a

Screenshot 2023-09-13 at 12 31 01 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants