Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Being able to inject in kube-system namespace #44

Closed
george-angel opened this issue Aug 11, 2020 · 0 comments · May be fixed by #53
Closed

Question: Being able to inject in kube-system namespace #44

george-angel opened this issue Aug 11, 2020 · 0 comments · May be fixed by #53

Comments

@george-angel
Copy link
Contributor

We would like to be able to inject sidecars inside kube-system namespace. Currently kube-system is hardcoded to be ignored: https://github.com/tumblr/k8s-sidecar-injector/blob/master/pkg/server/webhook.go#L81-L84

I guess this serves as protection from borking your cluster, but the controller fails open, so at worst it would slow down Pods starting in kube-system.

Is this something you would be open to having as a flag with current defaults, to allow setting an empty list?

Am I missing something more critical why kube-system and kube-public are ignored?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant