Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor into a library and contributing #16

Open
balazsdukai opened this issue Oct 24, 2023 · 2 comments · May be fixed by #17
Open

Refactor into a library and contributing #16

balazsdukai opened this issue Oct 24, 2023 · 2 comments · May be fixed by #17

Comments

@balazsdukai
Copy link
Member

Hello, we use your code for computing the shared walls in the 3DBAG and have a fork of your repo at https://github.com/3DGI/urban-morphology-3d .
However, our fork has diverged significantly, mostly for two reasons:

  1. we need to use the 3d-building-metrics as a library, so we've refactored the package accordingly,
  2. we've some 3DBAG-specific code in the cityStats module.

I would be happy to move our 3DBAG specific changes to a separate package and open a PR (or multiple PR's) with our changes for making the 3d-building-metrics usable as a library.
Are you open to this?
@lukasbeuster
Copy link

lukasbeuster commented Oct 24, 2023 •
edited
Loading

Hey, just chiming in on the sidelines, I'd definitely be interested in the refactored version of this so pretty please 👍

@StylianosVitalis-TomTom
Copy link

Hey @balazsdukai,

More than happy to have this PR. For what is worth, we are still working on the integration of most of the functionality in momepy, but I suppose this will only be about the indexes. So the part about shared walls calculation or comparing volumes won't make it to there. So, any PR to expose this in a more easy way would be very welcome. 👍

@balazsdukai balazsdukai linked a pull request Mar 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make a python package 3DGI/urban-morphology-3d
3 participants
@balazsdukai @lukasbeuster @StylianosVitalis-TomTom