-
Notifications
You must be signed in to change notification settings - Fork 160
lastfmcovers logging incorrect date (off by 273 years) & not pulling in covers #376
Comments
I don't know what the lastfmcovers plugin is. You should find the author -Brett On 27 Jun 2015, at 0:58, Brian Roach wrote:
|
Hi Brett, Bare with me - I'm still learning how github and all this works. So I downloaded the zip from the main Slogger repo and the lastfmcovers plugin was in the plugins_disabled folder. It does say "Based off Brett Terpstra's...with additions from Micah Cooper." Does that mean I should go to his page and open an issue or is there a way to tag him from here? What is the protocol? Brian |
Yes, or just @ mention his username in this thread to get him in on it. I haven't seen this date issue in my version yet, but not 100% that it's not a shared issue.
|
Ok. Sounds good. @coopermj could you please chime in on this. Having some trouble with the lastfmcovers.rb gem |
Well, that’s weird behavior. Just for fun, switch lastfm_chunk: from ‘’ to completely blank. It’s still purring along on my system and this is the only time I’ve heard someone having this problem. On Jun 27, 2015, at 1:25 PM, Brian Roach <[email protected]mailto:[email protected]> wrote: Ok. Sounds good. @coopermjhttps://github.com/coopermj could you please chime in on this. Having some trouble with the lastfmcovers.rb gem — |
No luck. Wouldn't run if I removed the |
Weird – that’s how mine is set. I just updated to the latest Slogger codebase and switched to Day One sync and it still works. When you use the original LastFM plugin, does it follow the same behavior? On Jun 29, 2015, at 4:30 PM, Brian Roach <[email protected]mailto:[email protected]> wrote: No luck. Wouldn't run if I removed the '' — |
This bug still exists. @coopermj did you test the configuration where Here you set I stopped debugging after finding this because I'm having a hard time following the code. So until this is fixed, the Sorry if this comes off negative. Just getting a bit frustrated with the general code quality and brittleness of Slogger plugins. |
I think a refund is in order.
|
Heh, I know @ttscoff... I do really appreciate the work you and others have done creating slogger. Apologies for my "entitled" response. |
Apologies for my "dickish" response, it was early in the morning :/.
|
I suppose all that’s left is for me to apologize for my lousy code! ;) Anyway, I think I’ve found the issue. Well, first issue is this is my first ruby script. Second, I’m attempting to solve 3 use cases in one and set the entry date to the period end instead of the period beginning. Obviously exacerbated by the long-period run. Anyway, I’m not a regular git user, so when I get that sorted out, I’ll issue a pull request with the fix. On Nov 14, 2015, at 10:36 PM, Brett Terpstra <[email protected]mailto:[email protected]> wrote: Apologies for my "dickish" response, it was early in the morning :/.
— |
Thanks @coopermj and again sorry for my crankiness! I appreciate your contributions! |
2 Centuries, 7 Decades, 3 years, 9 months, 1 week, and 4 days to be exact.
It's pulling in the scrobbled track data just fine, just not getting the covers and logging it to the correct date.
Here is what I have in my slogger_config file. Btw, even though I have the lastfmcovers.rb plugin enabled (and not the lastfmlogger.rb one) when I update the config, it still pulls in the LastFMLogger title as you can see below.
The text was updated successfully, but these errors were encountered: